View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000492LDMud 3.2Runtimepublic2006-11-13 22:202018-01-29 21:57
Reporterzippo Assigned Tolars 
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.2.13 
Fixed in Version3.2.16 
Summary0000492: crash with snoop + --check-refcounts
DescriptionThis is for version 3.2.14.

This is probably just a bad cut & paste. Crasher when current_object = 0, but I don't think current_object is even meant to be used here. Here's a patch that should work:

Index: comm.c
===================================================================
RCS file: /home/mud/cvsroot/driver/src/comm.c,v
retrieving revision 1.1.1.14
diff -u -r1.1.1.14 comm.c
--- comm.c 12 Nov 2006 20:15:04 -0000 1.1.1.14
+++ comm.c 14 Nov 2006 04:19:56 -0000
@@ -6873,7 +6873,7 @@
         if ( NULL != (ob = all_players[i]->snoop_by) ) {
             interactive_t *ip;

- if (!(O_SET_INTERACTIVE(ip, current_object)))
+ if (!(O_SET_INTERACTIVE(ip, ob)))
             {
                 /* snooping monster */
                 ob->extra_ref++;
TagsNo tags attached.

Activities

lars

2007-10-06 18:49

reporter   ~0000548

Indeed, that resolves the problem

Issue History

Date Modified Username Field Change
2006-11-13 22:20 zippo New Issue
2007-10-06 18:49 lars Status new => resolved
2007-10-06 18:49 lars Fixed in Version => 3.2.16
2007-10-06 18:49 lars Resolution open => fixed
2007-10-06 18:49 lars Assigned To => lars
2007-10-06 18:49 lars Note Added: 0000548
2010-11-16 09:42 lars Source_changeset_attached => ldmud.git master db97d86d
2010-11-16 09:42 lars Source_changeset_attached => ldmud.git master-3.2 b922abac
2018-01-29 18:59 lars Source_changeset_attached => ldmud.git master db97d86d
2018-01-29 18:59 lars Source_changeset_attached => ldmud.git master-3.2 b922abac
2018-01-29 21:57 lars Source_changeset_attached => ldmud.git master db97d86d
2018-01-29 21:57 lars Source_changeset_attached => ldmud.git master-3.2 b922abac