View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000501 | LDMud 3.3 | Efuns | public | 2007-02-21 11:44 | 2011-02-23 22:22 |
| Reporter | szalicil | Assigned To | zesstra | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Target Version | 3.3.720 | Fixed in Version | 3.3.720 | ||
| Summary | 0000501: get_dir("/",GETDIR_PATH) | ||||
| Description | get_dir("/",GETDIR_PATH) returns filenames without the leading slash [returns ({"tmp"})] (get_dir("/anyfolder/",GETDIR_PATH) correctly returns paths starting with / [returns ({"/tmp/somefile"})] ) | ||||
| Steps To Reproduce | #include <sys/files.h> get_dir("/",GETDIR_PATH) | ||||
| Tags | No tags attached. | ||||
|
|
Please don't change this without option for enabling the original behaviour. Most muds take care of this and a change will break existing code. |
|
|
I don't understand this. Why would you expect GETDIR_PATH to return the names without "/"? Isn't that what GETDIR_NAMES is for? |
|
|
In compat mode, get_dir(path, GETDIR_PATH) returns the path names without the leading slash. The behaviour that get_dir("/", GETDIR_PATH) works in native mode similar to compat mode, is a bug in my opinion. I personally expect get_dir() to return always paths with a leading slash. |
|
|
... when compiled in native mode! (forgot that part in my last note) |
|
|
I committed a fix for this in r2751 on trunk. "/" is prepended in plain mode also for the listing of the mudlib root directory, if paths are requested by GETDIR_PATH. Now the interesting question: should I apply this for trunk-3.3 as well? |
|
|
I'd say, yes. When I see issue 0000684, it could happen that the mudlib itself will strip that fixed slash again. Also apply a patch for 3.2, please! |
|
|
It is IMHO obvious, that this is a bug. And I think, it should be fixed. So I made a note in HISTORY and applied it in 3.3 as well in r2758. I think, fixing it in 3.2 it currently not really necessary. 3.2 is anyway obsolete and I know only Coogan/Tubmus who still use the branch. And they use compat mode and will there be not affected by any patch. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-02-21 11:44 | szalicil | New Issue | |
| 2007-02-22 12:12 | peng | Note Added: 0000527 | |
| 2009-10-01 15:30 | Gnomi | Note Added: 0001396 | |
| 2009-10-03 07:43 | Coogan | Note Added: 0001436 | |
| 2009-10-03 07:59 | Coogan | Note Added: 0001437 | |
| 2009-10-03 16:39 | zesstra | Note Added: 0001442 | |
| 2009-10-03 16:39 | zesstra | Status | new => assigned |
| 2009-10-03 16:39 | zesstra | Assigned To | => zesstra |
| 2009-10-03 16:47 | Coogan | Note Added: 0001443 | |
| 2009-10-05 15:58 | zesstra | Note Added: 0001473 | |
| 2009-10-05 15:58 | zesstra | Status | assigned => resolved |
| 2009-10-05 15:58 | zesstra | Fixed in Version | => 3.3.720 |
| 2009-10-05 15:58 | zesstra | Resolution | open => fixed |
| 2011-02-23 22:22 | zesstra | Target Version | => 3.3.720 |
