View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000825 | LDMud 3.5 | Implementation | public | 2013-08-18 18:52 | 2018-01-30 03:59 |
| Reporter | zesstra | Assigned To | zesstra | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Platform | x86_64 | OS | MacOS X | OS Version | 10.6.x |
| Target Version | 3.5.0 | Fixed in Version | 3.5.0 | ||
| Summary | 0000825: sprintf.c contains several theoretical buffer overflows with checks and fatal() calls | ||||
| Description | sprintf.c has 3 occurances of this construct: (writing with strcat/sprintf in temp) tmpl = strlen(temp); if ((size_t)tmpl >= sizeof(temp)) fatal("Local buffer overflow in sprintf() for int.\n"); These calls to fatal() are completely unnecessary, because we could use snprintf() or strncat() and prevent the buffer overflow in the first place. | ||||
| Tags | sprintf | ||||
|
|
Fixed in master now. |
|
|
Fix committed in revision ebf1fc941bd0668866cdaceeab81860617e3ec01 to master branch (see changeset 1485 for details). Thank you for reporting! |
|
|
Fix committed in revision ebf1fc941bd0668866cdaceeab81860617e3ec01 to master branch (see changeset 2814 for details). Thank you for reporting! |
|
|
Fix committed in revision ebf1fc941bd0668866cdaceeab81860617e3ec01 to master branch (see changeset 3898 for details). Thank you for reporting! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-08-18 18:52 | zesstra | New Issue | |
| 2013-08-18 23:02 | zesstra | Tag Attached: sprintf | |
| 2013-08-18 23:02 | zesstra | Assigned To | => zesstra |
| 2013-08-18 23:02 | zesstra | Status | new => assigned |
| 2013-08-30 23:08 | zesstra | Note Added: 0002208 | |
| 2013-08-30 23:08 | zesstra | Status | assigned => resolved |
| 2013-08-30 23:08 | zesstra | Fixed in Version | => 3.5.0 |
| 2013-08-30 23:08 | zesstra | Resolution | open => fixed |
| 2018-01-29 18:59 | zesstra | Source_changeset_attached | => ldmud.git master ebf1fc94 |
| 2018-01-29 18:59 | zesstra | Note Added: 0002317 | |
| 2018-01-29 21:57 | zesstra | Source_changeset_attached | => ldmud.git master ebf1fc94 |
| 2018-01-29 21:57 | zesstra | Note Added: 0002368 | |
| 2018-01-30 03:59 | zesstra | Source_changeset_attached | => ldmud.git master ebf1fc94 |
| 2018-01-30 03:59 | zesstra | Note Added: 0002419 |
