View Issue Details

IDProjectCategoryView StatusLast Update
0000039LDMud 3.2-devEfunspublic2004-05-17 07:27
Reportermenaures Assigned Tolars 
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Summary0000039: restore_value should complain more
Descriptionrestore_value should complain more about weird save strings.

Code:
---- 8< ----
restore_value(save_value(0)+"foobar")
---- 8< ----

In my opinion, this should raise an error. However, restore_value seems to simply stop parsing at the end of the actual save_value string and ignores the rest.

We had an object that saved save_value strings on disk using write_file(). However, that object forgot to delete the old savefiles, thus appending each new save to the old file, so that in the end the file looked like this:

---- 8< ----
0000001:0
value1
0000001:0
value2
...
0000001:0
valueN
---- 8< ----

with value1 being the oldest and valueN being the newest value. restore_value(read_file(file)) did always work, it never raised an error, thus this error went undetected for a long time :-)

Hopefully there are no MUDs using this appending stuff to a valuestring as a feature...
TagsNo tags attached.

Activities

lars

2004-04-03 15:34

reporter   ~0000041

Fixed in 3.2-dev.623 and 3.3.508.

Issue History

Date Modified Username Field Change
2004-01-02 01:27 menaures New Issue
2004-04-03 15:34 lars Status new => resolved
2004-04-03 15:34 lars Resolution open => fixed
2004-04-03 15:34 lars Assigned To => lars
2004-04-03 15:34 lars Note Added: 0000041
2004-05-17 07:27 lars Status resolved => closed